[publication] Fix number of files in Upload tab

[CamilleBeau]

Brief summary of changes

In this PR, the uploadForm.js file is modified to increase / decrease the numFiles value according to whether a file was actually selected or not. If a file is selected, the numFiles increases. If a file is not selected, the numFiles decreases.

This prevents the bug where "File to Upload" field is added indefinitely if the file is browsed and then cancelled.

• Have you updated related documentation?

Testing instructions (if applicable)

1. Go to the upload tab and upload a file.
2. Upload another file
3. Click browse next to the second file that was uploaded, and then cancel
4. Check that the file is removed, and that no extra "File to upload" fields are added (there should always be only one blank "File to upload" field)
5. Make sure that every time you browse and select a field, there is exactly one more "File to upload" field added to the bottom of the form.
6. If you have developer tools, check that the "numFiles" prop accurately reflects the number of file upload fields.

Link(s) to related issue(s)

• Resolves [publication] 'File to upload' dialog bug #9136

[jeffersoncasimir]

The issue appears to be resolved for new (proposed) projects, in uploadForm.js, but not when editing an existing project, in viewProject.js. (Tested on my VM)

[CamilleBeau]

The issue appears to be resolved for new (proposed) projects, in uploadForm.js, but not when editing an existing project, in viewProject.js. (Tested on my VM)

@jeffersoncasimir Fixed! Sorry about that

[driusan]

@CamilleBeau conflicts in the changelog
@jeffersoncasimir I'm assuming the changelog conflict won't prevent re-testing, can you re-check this?

[jeffersoncasimir]

The issue has been resolved!

[CamilleBeau]

The issue has been resolved!

Thanks! Conflict resolved.