Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[notification] Fix sender name in email #9203

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[notification] Fix sender name in email #9203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
456b215
fix email notification sender name
maximemuldermcgill Apr 11, 2024
60c432a
use fullname
maximemuldermcgill Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions php/libraries/NDB_Notifier.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,10 @@ class NDB_Notifier extends NDB_Notifier_Abstract
{
foreach ($this->notified['email_text'] as $name=>$uid) {
$notifierID = $this->notifier->getId();
$senderName = $this->notifier->getFullname();
$senderEmail = $this->notifier->getEmail();
$this->tpl_data['notified_user'] = $name;
$this->tpl_data['notifier_user'] = "$notifierID <$senderEmail>";
$this->tpl_data['notifier_user'] = "$senderName <$senderEmail>";
$recipientEmail = $this->getEmail((int)$uid);

if ($notifierID === $uid) {
Expand All @@ -99,7 +100,8 @@ class NDB_Notifier extends NDB_Notifier_Abstract
$this->template,
$this->tpl_data
);
$this->log((int)$notifierID, (int)$uid, 'email_text');

$this->log($notifierID, (int)$uid, 'email_text');
}
}
}
Expand Down
Loading