[Acknowledgements] Fix for selecting all roles

[skarya22]

Brief summary of changes

• Fixed the main issue by changing from insert to insertIgnore. With all the roles the string was just a tad too long for the regular insert.
• I also added a fix for not including "undefined" as a Role, Affiliation or Degree when the blank spot is selected

Testing instructions (if applicable)

1. Try adding an acknowledgement with different values for degrees, roles, and other fields
2. Confirm it adds as expected

Link(s) to related issue(s)

• Resolves [acknowledgements] 500 Error when all roles are selected when adding an entry #9173

[laemtl]

Tested and main fix works, all roles are saved. The second fix to remove the undefined value not work though, undefined is still present:

I wonder if the cleanup should be done on the frontend before it passes undefined.

I'm also curious about the reason insertIgnore vs insert fix the issue. @ridz1208, idea?

[laemtl]

See my comment above

[driusan]

why not do the array_filter before the implode on line 96/99/102?

[skarya22]

I think since the fields are strings and not arrays, it skips lines 96, 99, and 102. I didn't want to get rid of that part though as I don't know if there was some other reason for it. By doing it later it makes sure to do it for all cases without duplicating the codes on 96 and 97, 99 and 100, and 102 and 103

[skarya22]

Looks like this was caused by all the roles selected = character count > 258, and the sql column can only handle up till 255

[skarya22]

@laemtl turns out it worked as insertIgnore was ignoring the fact that it couldn't insert a value > than the sql table can handle. Definitely not the correct fix so I am re-doing it