Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[dashboard] Add project filter for tasks widget #9220

Merged

Conversation

CamilleBeau
Copy link
Contributor

@CamilleBeau CamilleBeau commented Apr 25, 2024

Brief summary of changes

This PR adds a project filter for TaskQueryWidget so that a user will only see the relevant tasks to their own project assignments.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Login with a user that has only one project
  2. Check that all of the task counts are relevant for only that project
  3. Take note that the Imaging tasks may not reflect what is shown in the table results that it links to, I have created a separate issue here for that.

Link(s) to related issue(s)

@CamilleBeau
Copy link
Contributor Author

Would anyone be able to help me with the test suite failures? I want to modify the test to check a user's project permissions properly, but I'm not sure where the project relevant to each individual section is inserted.

@CamilleBeau CamilleBeau added the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Apr 25, 2024
@kongtiaowang kongtiaowang self-assigned this Apr 29, 2024
@kongtiaowang
Copy link
Contributor

kongtiaowang commented Apr 29, 2024

@CamilleBeau please modify this file "modules/dashboard/test/DashboardTest.php", it will fix the test.
https://github.com/kongtiaowang/Loris/pull/398/files#diff-2af5e853d357c98c23e22e3a7d855bc560485103cb82026fa408d7fdf6f3fa5d

@kongtiaowang kongtiaowang removed the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Apr 29, 2024
@CamilleBeau CamilleBeau force-pushed the 2024_04_25_add_project_filter_task_widgets branch from 8417f4c to 1777b20 Compare May 9, 2024 14:35
@CamilleBeau
Copy link
Contributor Author

@CamilleBeau please modify this file "modules/dashboard/test/DashboardTest.php", it will fix the test. https://github.com/kongtiaowang/Loris/pull/398/files#diff-2af5e853d357c98c23e22e3a7d855bc560485103cb82026fa408d7fdf6f3fa5d

Thank you Shen!

@kongtiaowang kongtiaowang added the Passed Manual Tests PR has undergone proper testing by at least one peer label May 9, 2024
@driusan driusan merged commit fc1db13 into aces:main May 9, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[login] Incorrect request account approvals count on dashboard
4 participants