Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[RB_files] Sampling frequency updated in RB_physiological_parameter_file.sql #9241

Merged

Conversation

jeffersoncasimir
Copy link
Contributor

I noticed that the sampling frequency for the EEG data on RB is 256Hz instead of 512Hz.

It is the incorrect value for the dataset, and it also prevents filters from working on the signal, because coefficients are not defined for 256.

@jeffersoncasimir jeffersoncasimir added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels May 8, 2024
@jeffersoncasimir jeffersoncasimir changed the title Update sampling frequency in RB_physiological_parameter_file.sql [RB_files] Sampling frequency updated in RB_physiological_parameter_file.sql May 8, 2024
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 91243c0 into aces:main May 9, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants