Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[media] Remove instrument autoselect #9288

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

CamilleBeau
Copy link
Contributor

Brief summary of changes

This PR removes autoselect for the instrument field in the upload file form. This means that if there is only one instrument in the array, the one instrument will not be selected by default.

I also fixed a spacing issue that I saw in the uploadForm.js file, but is unrelated to this change.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Go to the "Upload" tab of the media module
  2. Find a PSCID / Visit combination that only has one instrument (if on raisinbread data, try V2 of DCC702)
  3. Make sure that after both a PSCID and Visit are entered, the instrument field remains blank and is not autoselected.

Link(s) to related issue(s)

@laemtl laemtl self-requested a review May 30, 2024 14:36
@driusan driusan merged commit e1fe8ee into aces:main Jun 3, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
maximemulder pushed a commit to maximemulder/Loris that referenced this pull request Sep 25, 2024
This removes autoselect for the instrument field in the upload file form. This means that if there is only one instrument in the array, the one instrument will not be selected by default.

Also fixed a spacing issue  in the uploadForm.js file, but is unrelated to this change.

Fixes aces#9272
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[media] Import bug fixes - users can't download, instrument auto-select
4 participants