[tools] fix instrument SQL generator script #9313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigned @CamilleBeau since we briefly discussed this issue this morning. |
ridz1208
approved these changes
Jul 30, 2024
maximemulder
added a commit
to maximemulder/Loris
that referenced
this pull request
Sep 25, 2024
Fix syntactically invalid SQL generation. Fix for aces#9312.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Fix for #9312.
The version before the regression generated broken SQL for
testname, which was then erased when the table was created.The regression was due to the erasement being removed.
This removes the broken SQL generation.
I don't know how critical this bug is but this PR should be in the next bugfix patch if there is one.
Testing instructions
Use the tools
lorisform_parser.phpandgenerate_tables_sql.phpscript to generate instrument SQL, and ensure this SQL is correct.