Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement PersistentTaskGroup #30

Merged
merged 9 commits into from
Jan 10, 2022
Merged

Conversation

achimnol
Copy link
Owner

@achimnol achimnol commented Dec 20, 2021

resolves #29

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #30 (ef1dcc9) into main (3a65b38) will increase coverage by 1.23%.
The diff coverage is 92.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   77.38%   78.61%   +1.23%     
==========================================
  Files          10       11       +1     
  Lines         849      926      +77     
==========================================
+ Hits          657      728      +71     
- Misses        192      198       +6     
Impacted Files Coverage Δ
src/aiotools/ptaskgroup.py 92.10% <92.10%> (ø)
src/aiotools/__init__.py 93.75% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a65b38...ef1dcc9. Read the comment docs.

@achimnol achimnol marked this pull request as ready for review December 20, 2021 07:19
@achimnol
Copy link
Owner Author

achimnol commented Dec 20, 2021

TODOs:

  • result streaming API (just for fun?)
  • more detailed logging options
  • more tests?
  • docs

@achimnol
Copy link
Owner Author

I'm going to merge this and follow the future work in new PRs.

@achimnol achimnol merged commit 07201ab into main Jan 10, 2022
@achimnol achimnol deleted the feature/persistent-task-group branch January 10, 2022 09:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent Task Group
1 participant