Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Set current_ptaskgroup only in async-with blocks #41

Merged
merged 4 commits into from
Mar 6, 2022

Conversation

achimnol
Copy link
Owner

@achimnol achimnol commented Mar 6, 2022

  • fix: Set current_ptaskgroup only in async-with blocks
  • docs: Add a warning about the new behavior

achimnol added 2 commits March 6, 2022 16:07
* For long-lived use case, this may cause "different context" errors
  if `shutdown()` is called from non-child tasks.
@achimnol achimnol added the bug label Mar 6, 2022
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #41 (50cd0eb) into main (f65cc97) will decrease coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   65.42%   65.41%   -0.01%     
==========================================
  Files          16       16              
  Lines        1284     1281       -3     
==========================================
- Hits          840      838       -2     
+ Misses        444      443       -1     
Impacted Files Coverage Δ
src/aiotools/taskgroup/persistent.py 0.00% <0.00%> (ø)
src/aiotools/taskgroup/persistent_compat.py 83.24% <100.00%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65cc97...50cd0eb. Read the comment docs.

@achimnol achimnol merged commit 97cb53d into main Mar 6, 2022
@achimnol achimnol deleted the fix/set-current_ptaskgroup-only-in-async-with-blocks branch March 6, 2022 16:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant