Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Feature detection for ExceptionGroup #42

Merged
merged 3 commits into from
Mar 6, 2022
Merged

Conversation

achimnol
Copy link
Owner

@achimnol achimnol commented Mar 6, 2022

  • Let MultiError inherit ExceptionGroup instead of BaseExceptionGroup,
    to be consistent with legacy MultiError.

* Let MultiError inherit ExceptionGroup instead of BaseExceptionGroup,
  to be consistent with legacy MultiError.
@achimnol achimnol added the bug label Mar 6, 2022
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #42 (7056ef3) into main (23df3eb) will increase coverage by 0.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   65.41%   65.96%   +0.54%     
==========================================
  Files          16       16              
  Lines        1281     1281              
==========================================
+ Hits          838      845       +7     
+ Misses        443      436       -7     
Impacted Files Coverage Δ
src/aiotools/taskgroup/base_compat.py 83.08% <ø> (ø)
src/aiotools/taskgroup/types.py 90.00% <100.00%> (+17.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23df3eb...7056ef3. Read the comment docs.

@achimnol achimnol merged commit 92105ae into main Mar 6, 2022
@achimnol achimnol deleted the fix/excgroup-detection branch March 6, 2022 17:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant