fix: Import in macOS (regression from #47) #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 78.66% 78.50% -0.17%
==========================================
Files 16 16
Lines 1336 1326 -10
==========================================
- Hits 1051 1041 -10
Misses 285 285
Continue to review full report at Codecov.
|
* The reason of prior failure was an unused ctypes init code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though
aiotools.forkandaiotools.servermodules do not support Windows, importing them is fine. The previously found error was due to an unused code:ctypes.CDLL(None).This PR removes those unused codes to avoid confusion and restore the import statements, as #47 has broken imports in macOS.