Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix a potential memory leak in PersistentTaskGroup #54

Merged
merged 7 commits into from
May 2, 2023

Conversation

achimnol
Copy link
Owner

@achimnol achimnol commented May 2, 2023

  • It no longer stores the unhandled exceptions from subtasks,
    as they will be kept for the whole lifespan of the
    PersistentTaskGroup.

- It no longer stores the unhandled exceptions from subtasks,
  as they will be kept for the whole lifespan of the
  PersistentTaskGroup.
@achimnol achimnol added the bug label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.57 🎉

Comparison is base (540daf2) 74.31% compared to head (0616890) 74.88%.

❗ Current head 0616890 differs from pull request most recent head eb8d186. Consider uploading reports for the commit eb8d186 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   74.31%   74.88%   +0.57%     
==========================================
  Files          17       17              
  Lines        1347     1322      -25     
==========================================
- Hits         1001      990      -11     
+ Misses        346      332      -14     
Impacted Files Coverage Δ
src/aiotools/server.py 48.98% <ø> (ø)
src/aiotools/func.py 98.03% <100.00%> (+0.03%) ⬆️
src/aiotools/taskgroup/__init__.py 100.00% <100.00%> (ø)
src/aiotools/taskgroup/persistent.py 90.53% <100.00%> (+3.16%) ⬆️
src/aiotools/taskgroup/persistent_compat.py 85.39% <100.00%> (+2.58%) ⬆️
src/aiotools/taskgroup/types.py 90.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achimnol achimnol merged commit 4a6e790 into main May 2, 2023
@achimnol achimnol deleted the fix/potential-memory-leak-with-ptaskgroup branch May 2, 2023 14:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant