Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improvements for ALC230 layout 20 and added layout 20 for ALC883 by samcabral #763

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Improvements for ALC230 layout 20 and added layout 20 for ALC883 by samcabral #763

merged 4 commits into from
Mar 7, 2022

Conversation

samcabral
Copy link
Contributor

@samcabral samcabral commented Feb 12, 2022 •
edited
Loading

Changes in ALC230

  • Removed Headset_dBV to fix noise in headphones
  • Changed MuteGPIO in LineIn to match PinComplex 25 (0x19)
  • Changed Boost in NodeID 25 to adjust input gain for external mic
  • Input gain for internal mic remains the same as my previous PR

Volume 88%
Audio Track 1 - Internal Mic
Audio Track 2 - External Mic

Boost 1

Boost 1

Boost 3

Boost 3

EDIT

codec_dump.txt

@samcabral
Copy link
Contributor Author

samcabral commented Feb 22, 2022 •
edited
Loading

Changes in ALC883

  • Changed Boost for mics
  • Added Boost 3 for Line In
  • Added MuteGPIO and SignalProcessing for LineIn and Mic

Works in Huananzhi X79G.

codec_dump.txt

photo_2022-02-21 22 13 51

photo_2022-02-21 22 13 46

@samcabral samcabral changed the title Fixed MuteGPIO and noise in headphones for layout 20 ALC230 by samcabral Improvements for layout 20 ALC230 and layout 7 ALC883 by samcabral Feb 22, 2022
@Andrey1970AppleLife
Copy link
Contributor

Changes in ALC883

  • Changed Boost for mics
  • Added Boost 3 for Line In
  • Added MuteGPIO and SignalProcessing for LineIn and Mic

Works in Huananzhi X79G.

Don't change layout 7, сreate new layout for ALC883. Otherwise PR will be closed.

@samcabral samcabral changed the title Improvements for layout 20 ALC230 and layout 7 ALC883 by samcabral Improvements for ALC230 layout 20 and added new layout for ALC883 by samcabral Feb 24, 2022
@samcabral
Copy link
Contributor Author

samcabral commented Feb 24, 2022 •
edited
Loading

I added a new layout as requested.

It works.

layout-id 20

Captura de Tela 2022-02-23 às 23 12 01

@Andrey1970AppleLife Andrey1970AppleLife changed the title Improvements for ALC230 layout 20 and added new layout for ALC883 by samcabral Improvements for ALC230 layout 20 and added layout 20 for ALC883 by samcabral Feb 24, 2022
@vit9696 vit9696 merged commit cccd084 into acidanthera:master Mar 7, 2022
@samcabral samcabral deleted the improvement branch March 9, 2022 10:20
@meloay
Copy link
Contributor

meloay commented Mar 10, 2022

I added a new layout as requested.
layout-id 72
ALC235 for Lenovo M920x by meloay
截屏2022-03-10 11 10 30
截屏2022-03-10 11 11 00
Artifacts.zip
codec#0.txt

@samcabral
Copy link
Contributor Author

@meloay you need to send PR to add your layout.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maiconjs maiconjs maiconjs approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samcabral @Andrey1970AppleLife @meloay @maiconjs @vit9696