Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add AMD iGPU detection via device-id (V2) #98

Merged
merged 22 commits into from
Sep 2, 2024

Conversation

Zormeister
Copy link
Contributor

@Zormeister Zormeister commented Aug 28, 2024

V2 as the last version broke iGPUs that aren't under the PCI Root Bridge.

Also, @vit9696 should line 309 be changed to check for videoBuiltin and not v.video?

@@ -209,6 +209,25 @@ void DeviceInfo::grabDevicesFromPciRoot(IORegistryEntry *pciRoot) {
DBGLOG("dev", "found IGPU device %s", safeString(name));
videoBuiltin = obj;
requestedExternalSwitchOff |= videoBuiltin->getProperty(RequestedExternalSwitchOffName) != nullptr;
} else if (vendor == WIOKit::VendorID::ATIAMD && (code == WIOKit::ClassCode::DisplayController || code == WIOKit::ClassCode::VGAController)) {
uint32_t dev = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this one a function? I do not like it being copy-pasted below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do.

@Zormeister Zormeister requested a review from vit9696 August 29, 2024 01:30
@vit9696 vit9696 merged commit 84fcf2d into acidanthera:master Sep 2, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants