Add AMD iGPU detection via device-id (V2) #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic constant was matched
vit9696
reviewed
Aug 28, 2024
Lilu/Sources/kern_devinfo.cpp
Outdated
| @@ -209,6 +209,25 @@ void DeviceInfo::grabDevicesFromPciRoot(IORegistryEntry *pciRoot) { | |||
| DBGLOG("dev", "found IGPU device %s", safeString(name)); | |||
| videoBuiltin = obj; | |||
| requestedExternalSwitchOff |= videoBuiltin->getProperty(RequestedExternalSwitchOffName) != nullptr; | |||
| } else if (vendor == WIOKit::VendorID::ATIAMD && (code == WIOKit::ClassCode::DisplayController || code == WIOKit::ClassCode::VGAController)) { | |||
| uint32_t dev = 0; | |||
There was a problem hiding this comment.
Could you make this one a function? I do not like it being copy-pasted below.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 as the last version broke iGPUs that aren't under the PCI Root Bridge.
Also, @vit9696 should line 309 be changed to check forvideoBuiltinand notv.video?