Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix inaccurate reporting of append dimension size in metadata. #286

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

aliddell
Copy link
Member

@aliddell aliddell commented Aug 8, 2024

I noticed an issue where the shape of the array in the final dimension was always reported as the number of frames acquired, which, in the case of nontrivial internal dimensions, is just wrong. Opening up such a dataset in napari will confirm.

Copy link
Contributor

@jeskesen jeskesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because my comments are more a stylistic suggestion than anything, and shouldn't be blocking.

I will also note that the fact that had to copy/paste the same suggestion suggests copy/pasted code (which IMHO should be a avoided).

Copy link
Contributor

@jeskesen jeskesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because my comments are more a stylistic suggestion than anything, and shouldn't be blocking.

I will also note that the fact that had to copy/paste the same suggestion suggests copy/pasted code (which IMHO should be a avoided).

aliddell and others added 2 commits August 9, 2024 09:41
Co-authored-by: Justin Eskesen <jeskesen@chanzuckerberg.com>
@aliddell aliddell merged commit c54c8f3 into acquire-project:main Aug 9, 2024
3 checks passed
@aliddell aliddell deleted the fix-metadata branch August 9, 2024 17:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants