Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add acquire-zarr as a submodule #308

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Add acquire-zarr as a submodule #308

merged 4 commits into from
Oct 25, 2024

Conversation

aliddell
Copy link
Member

  • Add acquire-zarr submodule
  • Make CMake options of informal definitions NOTEST and WITH_EXAMPLES
    • Conditionally include directories based on option values
  • Move src/driver/* to src/
  • Move tests/driver/* to tests/
  • Remove all streaming code

@aliddell aliddell requested a review from jeskesen October 24, 2024 19:10
@aliddell
Copy link
Member Author

It looks like a lot, but most things are just deletes and moves.

jeskesen
jeskesen approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jeskesen jeskesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at my comment. This should probably be done now, to align it with what the acquire-zarr submodule does.

I'm approving, just to not block it when that (trivial) fix is done.

CMakeLists.txt Outdated

add_subdirectory(src)
add_subdirectory(tests)
add_subdirectory(examples)
if (NOT NOTEST)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrate this to use ENABLE_TESTING?

@aliddell aliddell merged commit b1f1ff3 into acquire-project:main Oct 25, 2024
3 checks passed
@aliddell aliddell deleted the streaming-submodule branch October 25, 2024 18:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jeskesen jeskesen jeskesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliddell @jeskesen