url-helper.ts now leverages well-known environment variables.
#1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jww3
commented
Oct 11, 2024
jww3
commented
Oct 11, 2024
jww3
commented
Oct 11, 2024
jww3
commented
Oct 16, 2024
jww3
commented
Oct 16, 2024
easyt
reviewed
Oct 16, 2024
easyt
reviewed
Oct 16, 2024
easyt
reviewed
Oct 16, 2024
Co-authored-by: Erez Testiler <easyt@github.com>
easyt
approved these changes
Oct 17, 2024
joshmgross
reviewed
Oct 17, 2024
joshmgross
previously approved these changes
Oct 17, 2024
joshmgross
approved these changes
Oct 17, 2024
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Oct 24, 2024
| datasource | package | from | to | | ----------- | ---------------- | ------ | ------ | | github-tags | actions/checkout | v4.1.7 | v4.2.2 | ## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422) - `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941 - Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946 ## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421) - Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924 ## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420) - Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180 - Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 16, 2024
| datasource | package | from | to | | ----------- | ---------------- | ------ | ------ | | github-tags | actions/checkout | v4.1.7 | v4.2.2 | ## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422) - `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941 - Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946 ## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421) - Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924 ## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420) - Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180 - Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 16, 2024
| datasource | package | from | to | | ----------- | ---------------- | ------ | ------ | | github-tags | actions/checkout | v4.1.7 | v4.2.2 | ## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422) - `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941 - Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946 ## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421) - Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924 ## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420) - Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180 - Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 16, 2024
| datasource | package | from | to | | ----------- | ---------------- | ------ | ------ | | github-tags | actions/checkout | v4.1.7 | v4.2.2 | ## [vv4.2.2](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v422) - `url-helper.ts` now leverages well-known environment variables by [@jww3](https://github.com/jww3) in actions/checkout#1941 - Expand unit test coverage for `isGhes` by [@jww3](https://github.com/jww3) in actions/checkout#1946 ## [vv4.2.1](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v421) - Check out other refs/\* by commit if provided, fall back to ref by [@orhantoy](https://github.com/orhantoy) in actions/checkout#1924 ## [vv4.2.0](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v420) - Add Ref and Commit outputs by [@lucacome](https://github.com/lucacome) in actions/checkout#1180 - Dependency updates by [@dependabot-](https://github.com/dependabot-) actions/checkout#1777, actions/checkout#1872
This was referenced Dec 31, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url-helper.tshad unnecessary complexity which could cause it to incorrectly infer common URLs.This fix leverages well-known environment variables for the purposes of determining common URLs.