Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update transitive dependency spdx-license-ids #855

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ailox
Copy link

@ailox ailox commented Dec 6, 2024

New licenses were added 7 months ago in jslicense/spdx-license-ids@6a6cd1d, but this logic is not used yet.

This PR fixes #854 as it updates the transient dependency, so that it is possible to use the Licenses.

@ailox ailox requested a review from a team as a code owner December 6, 2024 15:40
@ailox
Copy link
Author

ailox commented Dec 6, 2024

If helpful, I can also add a test that uses one of the newer licenses, so the resolution can be validated

@brrygrdn
Copy link
Contributor

👋🏻 Thanks for this contribution @ailox, this looks good to me. Would you mind running npm run package and checking in the dist changes on your branch? All the other checks are 👍🏻.

I don't think it's worth adding a unit specifically for the new licenses, but thanks for bringing it up!

@ailox
Copy link
Author

ailox commented Jan 9, 2025

I ran the command you supplied. I was struggling a little since the project had to be npm build first

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] action does fail with valid licenses like Unicode-3.0
2 participants