This repository was archived by the owner on May 3, 2022. It is now read-only.
Redirects should not pass authorization to different domain #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmacfarlane
commented
Apr 23, 2020
| @@ -386,6 +386,16 @@ export class HttpClient { | |||
| // which will leak the open socket. | |||
| await response.readBody() | |||
|
|
|||
| // strip authorization header if redirected to a different hostname | |||
There was a problem hiding this comment.
Note that I commented out these lines and confirmed tests failed. Then uncommented and both pass
bryanmacfarlane
commented
Apr 23, 2020
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@actions/http-client", | |||
| "version": "1.0.7", | |||
| "version": "1.0.8", | |||
There was a problem hiding this comment.
only a patch bump to ensure as many folks as possible just get the fix. I will also post a security advisory
ericsciple
approved these changes
Apr 23, 2020
1 task
1 task
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a request is redirected to a different domain, the authorization header should be stripped.