Remove unneeded base64 encoders #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // 000000|00 0000|0000 00|000000| 000000|00 0000|0000 00|000000| | ||
| // Char1 Char2 Char3 Char4 | ||
| // See the above, the first byte has a character beginning at index 0, the second byte has a character beginning at index 4, the third byte has a character beginning at index 2 and then the pattern repeats | ||
| // We register byte offsets for all these possible values | ||
| public static String Base64StringEscapeShift1(String value) |
There was a problem hiding this comment.
should we keep 0/2/4? not 0/1/2
There was a problem hiding this comment.
Right, I thought it was the even bit shifts ...
There was a problem hiding this comment.
it should be 0/1/2, since it's byte... not bit...
the shift is for shifting bytes.
There was a problem hiding this comment.
I added an L0 for this: #129
There was a problem hiding this comment.
I added a Server side pr with tests as well!
The ticket has information on why these shifts were selected!
TingluoHuang
approved these changes
Oct 13, 2019
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* Remove unneeded base64 encoders * update comment
volker-raschek
pushed a commit
to dedalus-cis4u/github-runner-role
that referenced
this pull request
Jul 25, 2022
Allow runner_org to be provided as string.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Server PR with test!
Essentially, these extra encoders weren't really doing anything besides slowing down compute, so we are safe to remove them.