Default to pwsh with powershell as a fallback #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliobbv
reviewed
Oct 23, 2019
| if(validateShellOnHost) | ||
| { | ||
| shellCommandPath = WhichUtil.Which(shellCommand, true, Trace); | ||
| shellCommandPath = WhichUtil.Which(shellCommand, false, Trace); |
There was a problem hiding this comment.
I'd specify the second parameter with a named instance. false is kind of hard to understand what it does.
|
LGTM. We have to move quickly on this to get it going today. We need it out to ring 0 ASAP and then ring 2 by EOD and ring 1 tomorrow morning. @chrispat |
ericsciple
approved these changes
Oct 23, 2019
juliobbv
approved these changes
Oct 23, 2019
|
Going to merge this, ran the tests locally, and see if we can get a release build working |
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* Default to pwsh with powershell as a fallback * Update releaseNote.md * clean up code
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.