Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix missing default user-agent for jitconfig runner. #3473

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix missing default user-agent for jitconfig runner. #3473

merged 3 commits into from
Sep 25, 2024

Conversation

TingluoHuang
Copy link
Member

user-agent for jitconfig runner:

before the fix:

User-Agent: VSServices/2.319.1.0 (NetStandard; Darwin 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000) 
GitHubActionsRunner-osx-arm64/2.319.1 
HttpProxyConfigured/True 
CommitSHA/ddf41af7678a8bc585d9e6b8ab70d941cdb687b2 Pid/14771 CreationTime/2024-09-24T20%3A51%3A42.2059570Z (Runner) 
(Darwin 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000)

After the fix:

User-Agent: VSServices/2.319.1.0 (NetStandard; Darwin 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000) 
GitHubActionsRunner-osx-arm64/2.319.1 
HttpProxyConfigured/True 
ClientId/9a33a1f3-b0b8-4be9-a1f2-d427f0e64fee RunnerId/1211326 GroupId/1 
CommitSHA/ddf41af7678a8bc585d9e6b8ab70d941cdb687b2 Pid/14384 CreationTime/2024-09-24T20%3A51%3A24.5314530Z (Runner) 
(Darwin 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000)

@TingluoHuang TingluoHuang requested a review from a team as a code owner September 24, 2024 21:02
TingluoHuang
TingluoHuang commented Sep 24, 2024
View reviewed changes
.github/workflows/build.yml
@@ -75,7 +75,7 @@ jobs:
# Upload runner package tar.gz/zip as artifact
- name: Publish Artifact
if: github.event_name != 'pull_request'
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1/v2 get deprecated...

rentziass
rentziass previously approved these changes Sep 24, 2024
View reviewed changes
pje
pje previously approved these changes Sep 24, 2024
View reviewed changes
@TingluoHuang TingluoHuang dismissed stale reviews from pje and rentziass via 8e5dbb4 September 24, 2024 22:23
@TingluoHuang TingluoHuang merged commit 6d7446a into main Sep 25, 2024
10 checks passed
@TingluoHuang TingluoHuang deleted the users/tihuang/ua branch September 25, 2024 13:01
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
fmartinez255 pushed a commit to TiVo/actions-runner that referenced this pull request Oct 7, 2024
@TingluoHuang @fmartinez255
fix missing default user-agent for jitconfig runner. (actions#3473)
795ab0d
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rentziass rentziass rentziass approved these changes

@pje pje pje left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TingluoHuang @pje @rentziass