Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Print node version in debug instead of output. #433

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

TingluoHuang
Copy link
Member

@TingluoHuang TingluoHuang commented Apr 17, 2020

The customer doesn't care what node version the infrastructure is using, so we should not put this info into every user-facing log.

@bryanmacfarlane
Copy link
Member

Yes!

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang merged commit c5fa9fb into master Apr 17, 2020
@TingluoHuang TingluoHuang deleted the users/tihuang/debugnodeversion branch April 17, 2020 15:53
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants