Help trace worker crash in Kusto. #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
commented
Apr 23, 2020
TingluoHuang
commented
Apr 24, 2020
src/Runner.Listener/JobDispatcher.cs
Outdated
| @@ -952,8 +951,10 @@ private async Task LogWorkerProcessUnhandledException(Pipelines.AgentJobRequestM | |||
| ArgUtil.NotNull(timeline, nameof(timeline)); | |||
| TimelineRecord jobRecord = timeline.Records.FirstOrDefault(x => x.Id == message.JobId && x.RecordType == "Job"); | |||
| ArgUtil.NotNull(jobRecord, nameof(jobRecord)); | |||
| var unhandledExceptionIssue = new Issue() { Type = IssueType.Error, Message = errorMessage }; | |||
| unhandledExceptionIssue.Data[Constants.Runner.WorkerCrashIssueDataKey] = string.Empty; | |||
There was a problem hiding this comment.
service will check the issue data to decide whether fire product trace event.
There was a problem hiding this comment.
Think about:
Should we make this more generic? Do we have any other cases that warrant a more generic telemetry mechanism, e.g. [...].Data["_telemetry"] = "WORKER_CRASH"
ericsciple
reviewed
Apr 27, 2020
| @@ -486,7 +486,10 @@ public void ProcessCommand(IExecutionContext context, string inputLine, ActionCo | |||
|
|
|||
| foreach (var property in command.Properties) | |||
| { | |||
| issue.Data[property.Key] = property.Value; | |||
| if (!string.Equals(property.Key, Constants.Runner.WorkerCrashIssueDataKey, StringComparison.OrdinalIgnoreCase)) | |||
There was a problem hiding this comment.
dont we already filter everything other than specific properties?
ericsciple
approved these changes
Apr 27, 2020
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* Help trace worker crash in Kusto. * more * feedback.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the Actions hosted runner virtual environment that causes the available disk space reduced. http://github.com/actions/virtual-environments/issues/709
Some customer's workflow used all disk space and cause the runner crash as well.
We want to get alert when the number of worker crash increase, so we can proactively investigate these issue instead of waiting for customer report.
Each worker crash means there is a failed workflow run and the customer is not happy with it.