Sps/token migration tweak, ActionResult casing. #462
Conversation
| @@ -572,7 +597,7 @@ private async Task<VssCredentials> GetNewOAuthAuthorizationSetting(CancellationT | |||
| Trace.Verbose("No authorization url updates"); | |||
| } | |||
| } | |||
| catch (Exception ex) | |||
| catch (Exception ex) when (!token.IsCancellationRequested) | |||
There was a problem hiding this comment.
don't report migration error when user ctrl-c the runner.
| { | ||
| Trace.Info("Start checking oauth authorization url update."); | ||
| while (true) | ||
| { | ||
| var backoff = BackoffTimerHelper.GetRandomBackoff(TimeSpan.FromMinutes(30), TimeSpan.FromMinutes(45)); |
There was a problem hiding this comment.
move the sleep to the end of the iteration, since most runner has finished migration. there are a small number of runners connected to the server once a while only for a few minutes, so the delay is too long for them.
| @@ -164,6 +164,27 @@ public async Task<Boolean> CreateSessionAsync(CancellationToken token) | |||
| } | |||
| } | |||
|
|
|||
| if (ex is TaskAgentSessionConflictException) | |||
There was a problem hiding this comment.
try migration even on session conflict since there are a small number of runners (might be orchestrated by some auto-provision/scaling tools) hitting session conflict all the time.
| @@ -21,7 +21,7 @@ public sealed class JobContext : DictionaryContextData | |||
| } | |||
| set | |||
| { | |||
| this["status"] = new StringContextData(value.ToString()); | |||
| this["status"] = new StringContextData(value.ToString().ToLowerInvariant()); | |||
There was a problem hiding this comment.
change to lower case to match GitHub check result
| { | ||
| var step = GetStep(scopeName, stepName); | ||
| step["conclusion"] = new StringContextData(conclusion); | ||
| step["conclusion"] = new StringContextData(conclusion.ToString().ToLowerInvariant()); |
There was a problem hiding this comment.
change to lower case to match GitHub check result
| { | ||
| var step = GetStep(scopeName, stepName); | ||
| step["outcome"] = new StringContextData(outcome); | ||
| step["outcome"] = new StringContextData(outcome.ToString().ToLowerInvariant()); |
There was a problem hiding this comment.
change to lower case to match GitHub check result
TingluoHuang
force-pushed
the
users/tihuang/stuff
branch
from
4d0636f to
c5d5a2a
Compare
No description provided.