docker build using -f instead of implied default #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| return await ExecuteDockerCommandAsync(context, "build", $"-t {tag} \"{dockerFile}\"", workingDirectory, context.CancellationToken); | ||
| return await ExecuteDockerCommandAsync(context, "build", $"-t {tag} -f \"{dockerFile}\" {dockerContext}", workingDirectory, context.CancellationToken); |
There was a problem hiding this comment.
do we need to quote {dockerContext}?
There was a problem hiding this comment.
Probably. It works either way with my samples but I think if theres a whitespace or maybe other weird characters in the path it could get split / not work without quotes so I added them
| ExecutionContext, | ||
| ExecutionContext.GetGitHubContext("workspace"), | ||
| dockerFile, | ||
| Directory.GetParent(dockerFile).FullName, imageName); |
There was a problem hiding this comment.
imageName on the newline. 😄
TingluoHuang
approved these changes
May 11, 2020
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
* pass -f to docker build * Wrong place * build path * Also pass docker context path * Tidy up format * PR Feedback
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you specify
image: './path/to/dockerfile.Dockerfileinstead of requiring the filename to be justDockerfile.Passes the existing filename to
buildexplicitly with-fbut continues passing the directory containing the dockerfile to indicate the docker context, rather than assuming it will contain "Dockerfile" by default.e.g. in an action you can now have (under image):