Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding wrapper action to support post job cleanup, checkout just work #91

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Adding wrapper action to support post job cleanup, checkout just work #91

merged 1 commit into from
Sep 24, 2019

Conversation

TingluoHuang
Copy link
Member

No description provided.

@TingluoHuang TingluoHuang changed the title [WIP] adding wrapper action to support post job cleanup Adding wrapper action to support post job cleanup, checkout just work Aug 30, 2019
@TingluoHuang TingluoHuang force-pushed the users/tihuang/wrapperaction branch 5 times, most recently from 6bca89d to f4094e7 Compare September 16, 2019 02:32
thboop
thboop reviewed Sep 16, 2019
View reviewed changes
src/Runner.Plugins/Repository/v1.1/GitSourceProvider.cs
// Prepare self-signed CA cert config for fetch from server.
if (useSelfSignedCACert)
{
executionContext.Debug($"Use self-signed certificate '{runnerCert.CACertificateFile}' for git fetch.");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does fetch work differently here, just curious

thboop
thboop reviewed Sep 16, 2019
View reviewed changes
src/Test/L0/Worker/ActionManagerL0.cs
}
else
{
throw new NotSupportedException(key);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider assert.fail

@TingluoHuang TingluoHuang force-pushed the users/tihuang/wrapperaction branch from f4094e7 to 3486b82 Compare September 17, 2019 03:10
thboop
thboop approved these changes Sep 17, 2019
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the git commands are a little outside my area of expertise so you may want to consider getting someone else to review that or we can sit in a room and discuss it if you are worried about it.

@TingluoHuang TingluoHuang force-pushed the users/tihuang/wrapperaction branch from 3486b82 to bf5b001 Compare September 19, 2019 17:27
@TingluoHuang TingluoHuang force-pushed the users/tihuang/wrapperaction branch from 4b2e2f4 to 97ada5d Compare September 23, 2019 21:10
@TingluoHuang TingluoHuang merged commit 684d4a7 into master Sep 24, 2019
@TingluoHuang TingluoHuang deleted the users/tihuang/wrapperaction branch September 24, 2019 00:29
fhammerl added a commit that referenced this pull request Jun 16, 2022
@fhammerl
Merge pull request #91 from fhammerl/fhammerl/exception-wrap
f363c5a 
Handle exception in executeHookScript
volker-raschek pushed a commit to dedalus-cis4u/github-runner-role that referenced this pull request Jul 25, 2022
@MonolithProjects
Merge pull request actions#91 from MonolithProjects/develop
52ce09e 
Develop to Master
jsoref pushed a commit to jsoref/actions-runner that referenced this pull request Oct 7, 2022
@ChristopherHX
rerun failed, ignore succeeded in previous rerun (actions#91)
8f61922
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TingluoHuang @thboop @tingluohuang-test