-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Include version catalog file in filehash in the Gradle cache key #237
Comments
Just as an FYI there's less need for this for me personally as I will use gradle/gradle-build-action@v2 which has more robust support for caching dependencies as well as other build outputs like Gradle's build & configuration caches. |
Hello @3flex. Sorry for the late response. You can publish a pull request with adding new file caching. If you do not want we will add this caching by our own. |
Sorry, I won't be working on a PR. On the best pattern, I'm not sure - |
We'll prepare a pull request later. We keep the issue opened until the pull request is merged. |
close actions#237 Signed-off-by: Kengo TODA <skypencil+github@gmail.com>
Description:
Add
libs.versions.toml
or*.versions.toml
to the cache key for Gradle dependency caching.Justification:
Central declaration of dependencies is an incubating Gradle feature that supports centralisation of configuration of dependencies & versions. By convention this is done in a file named
libs.versions.toml
: https://docs.gradle.org/7.2/userguide/platforms.html#sub:conventional-dependencies-tomlProjects that start using this feature can't practically use the Gradle caching feature in setup-java because the cache key will not change in most cases when dependencies are updated in the TOML file.
Are you willing to submit a PR?
Yes - if this change is acceptable.Edit: no, as I will be using gradle/gradle-build-action@v2 instead which I discovered after raising this issue.The text was updated successfully, but these errors were encountered: