Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove restoreKeys to clear cache after update #285

Conversation

schuenadel
Copy link
Contributor

Description:
Suggestion (like commented here) to remove fallback hash key to avoid keeping dependencies "forever". Start with a completely clean cache whenever any dependency changes.

Related issue:
#269

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@schuenadel schuenadel changed the title Remove "restoreKeys" to clear cache after update Remove restoreKeys to clear cache after update Jan 25, 2022
@dmitry-shibanov
Copy link
Contributor

Hello @schuenadel. Could you please sync with the main branch ?

@schuenadel schuenadel requested a review from a team April 19, 2022 10:45
@schuenadel
Copy link
Contributor Author

@dmitry-shibanov done ✅

@paramaggarwal
Copy link

This is a bad change, this effectively makes caching useless when the linked file like pom.xml has even a tiny change.

@thomasmey
Copy link

Yes, setup-java should use a per build system strategy for setting the restore-keys, for maven build system this change is really bad

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants