Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add execution state information #499

Merged
merged 3 commits into from
Jun 26, 2020
Merged

Add execution state information #499

merged 3 commits into from
Jun 26, 2020

Conversation

8398a7
Copy link
Contributor

@8398a7 8398a7 commented Jun 14, 2020

I created a PR because I wanted this feature too.

I've been dealing with the following workaround, but it would be nice to be able to use it in the library.
https://github.com/8398a7/action-slack/blob/v3.1.0/src/client.ts#L143

Resolves: #371

@8398a7 8398a7 changed the title Add execution state information (#371) Add execution state information Jun 14, 2020
@8398a7
Copy link
Contributor Author

8398a7 commented Jun 14, 2020

I would like to add GITHUB_JOB as well, if that's OK with you.
https://github.com/8398a7/action-slack/blob/v3.1.0/src/client.ts#L150

@@ -15,6 +15,8 @@ export class Context {
workflow: string
action: string
actor: string
runNumber: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @8398a7 , runNumber and runId are numbers in the rest api , we should match that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
I fixed it in 728bcb5.

@thboop
Copy link
Collaborator

thboop commented Jun 25, 2020

I would like to add GITHUB_JOB as well, if that's OK with you.

Sounds great! This PR looks good, do you want to open a separate pr for this, or amend this one?

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@8398a7
Copy link
Contributor Author

8398a7 commented Jun 25, 2020

Sounds great! This PR looks good, do you want to open a separate pr for this, or amend this one?

Thank you. I've made some changes to this PR.

I made a mistake in the template for the commit message. I did a force push to fix it. Sorry.

Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job changes LGTM

@thboop thboop merged commit 2d47f7b into actions:master Jun 26, 2020
@thboop
Copy link
Collaborator

thboop commented Jun 26, 2020

Going to include this in the 4.0.0 release. Thank you for the contribution!

#507

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@actions/github should populate Run Number and Run ID
2 participants