New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add notice annotation and support more annotation fields #855

Merged

luketomlinson merged 9 commits into main from annotations-updates

Jul 28, 2021

Contributor

luketomlinson commented Jun 29, 2021 •

edited

Loading

This PR adds support for:

The notice annotation level.
The title, line, endLine, col, and endColumn fields.

Depends on these runner changes.

luketomlinson requested a review from a team as a code owner

June 29, 2021 18:35

luketomlinson commented

View reviewed changes

packages/core/src/core.ts Outdated Show resolved Hide resolved

luketomlinson force-pushed the annotations-updates branch from 50ea325 to f786863 Compare

June 29, 2021 19:19

thboop reviewed

View reviewed changes

packages/core/src/utils.ts Outdated Show resolved Hide resolved

thboop reviewed

View reviewed changes

packages/core/src/utils.ts Outdated Show resolved Hide resolved

thboop reviewed

View reviewed changes

packages/core/src/utils.ts Show resolved Hide resolved

thboop reviewed

View reviewed changes

packages/core/src/core.ts Show resolved Hide resolved

thboop reviewed

View reviewed changes

packages/core/src/core.ts Show resolved Hide resolved

luketomlinson added 4 commits

July 2, 2021 15:03


          Add support for notice annotation and additional properties

fe09733


          Add additional tests

b3d7aa3


          Update readme

4b50f8c


          Change casing for endLine and endColumn

a5df6ef

luketomlinson force-pushed the annotations-updates branch from e05b631 to a5df6ef Compare

July 2, 2021 19:03


          Update utils.ts

397ffad

thboop approved these changes

View reviewed changes

Collaborator

thboop left a comment

LGTM

ericsciple reviewed

View reviewed changes

packages/core/README.md Show resolved Hide resolved

thboop reviewed

View reviewed changes

packages/core/src/utils.ts Outdated Show resolved Hide resolved

ericsciple reviewed

View reviewed changes

packages/core/README.md Show resolved Hide resolved

ericsciple reviewed

View reviewed changes

packages/core/src/command.ts Show resolved Hide resolved

luketomlinson added 2 commits

July 13, 2021 12:32


          Update README.md

f1d9385


          Rename files to have internal- nomenclature

ericsciple approved these changes

View reviewed changes

luketomlinson added 2 commits

July 14, 2021 09:18


          Revert "Rename files to have internal- nomenclature"

This reverts commit 7911689.


          Update utils.ts

7235d70

luketomlinson merged commit f0b00fd into main

luketomlinson deleted the annotations-updates branch

July 28, 2021 21:34

vitaliimelnychuk mentioned this pull request

use github toolkit for annotations barecheck/code-coverage-action#101

Open

warnyul mentioned this pull request

Update @actions/core to 1.10.0 jwenz723/github-app-installation-token#4

Merged

github-actions bot mentioned this pull request

Upgraded some dependencies - Attempt 2 AurorNZ/report-updated-dependencies#638

Merged

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet