Skip to content

Support for rails 6 #183

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Jul 24, 2020
Merged

Support for rails 6 #183

merged 6 commits into from
Jul 24, 2020

Conversation

pnghai
Copy link
Contributor

@pnghai pnghai commented Apr 20, 2020

fix Rubyzip conflict with webdriver and selenium driver (rubyzip >=1.2.2) on Rails 6

  In Gemfile:
    active_admin_import was resolved to 4.2.0, which depends on
      rubyzip (~> 1.2)

    selenium-webdriver was resolved to 3.142.7, which depends on
      rubyzip (>= 1.2.2)

    webdrivers was resolved to 4.2.0, which depends on
      rubyzip (>= 1.3.0)

@coveralls
Copy link

coveralls commented Apr 20, 2020

Coverage Status

Coverage increased (+0.003%) to 97.959% when pulling 3b634f4 on pnghai:master into 07cee9c on activeadmin-plugins:master.

@pnghai pnghai changed the title Update active_admin_import.gemspec Support for rails 6 Jul 20, 2020
@pnghai
Copy link
Contributor Author

pnghai commented Jul 21, 2020

@Fivell Please consider this when you have time

@workgena workgena requested a review from Fivell July 21, 2020 14:02
@Fivell Fivell merged commit d0efd09 into activeadmin-plugins:master Jul 24, 2020
@Fivell
Copy link
Member

Fivell commented Jul 24, 2020

@pnghai thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants