Run gherkin-lint through yarn
#5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix_rake_lint
branch
from
b35cf44 to
797e8ef
Compare
deivid-rodriguez
force-pushed
the
fix_rake_lint
branch
from
7fdc7bd to
b7348b7
Compare
|
Should be ready now! |
|
Awesome thanks David! 🙌🏻 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched from
npmtoyarnin #5868, but we didn't migrate therake linttask to use yarn as well. Also took the chance to upgradegherkin-lint.@leio10 discovered that
gherkin-lintis currently failing in CI in #5938. Surprisingly, it's not making the CI fail, but it seems to me that it's due to a bug innpxnot transmitting the status code of the executable is running. Since we're migrating away fromnpx, it doesn't really matter.