Use ruby2_keywords for the moment
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
ruby2_keywords
branch
from
ea28993 to
9bbb771
Compare
|
@javierjulio After a second look, I believe the most conservative option is to use |
Without this gem, current activeadmin version becomes incompatible with the master branch of `arbre`. It shouldn't be an issue as long as we update activeadmin's code to use keyword arguments everywhere, set a minimum dependency on the next `arbre` and release both gems at the same time, but I think it's easier to be conservative.
deivid-rodriguez
force-pushed
the
ruby2_keywords
branch
from
9bbb771 to
26a4391
Compare
javierjulio
approved these changes
May 21, 2020
|
I didn't spend time understanding it either, I just run activeadmin test suite against current arbre's master and stuff failed like this: With this PR nothing fails. I also noticed that everything is fine with activeadmin/activeadmin#6237, but still I don't want to leave any combination where things could break for users. |
|
Ha even then though that output says a lot. Yes, I agree, with the gem at least we know for sure it's compatible. Thanks! Let's do it. 👍🏻 |
omitter
added a commit
to omitter/arbre
that referenced
this pull request
Dec 23, 2021
varyonic
pushed a commit
to varyonic/arbo
that referenced
this pull request
Nov 23, 2022
Without this gem, current activeadmin version becomes incompatible with the master branch of `arbre`. It shouldn't be an issue as long as we update activeadmin's code to use keyword arguments everywhere, set a minimum dependency on the next `arbre` and release both gems at the same time, but I think it's easier to be conservative.
varyonic
pushed a commit
to varyonic/arbo
that referenced
this pull request
Nov 23, 2022
Without this gem, current activeadmin version becomes incompatible with the master branch of `arbre`. It shouldn't be an issue as long as we update activeadmin's code to use keyword arguments everywhere, set a minimum dependency on the next `arbre` and release both gems at the same time, but I think it's easier to be conservative.
varyonic
pushed a commit
to varyonic/arbo
that referenced
this pull request
Dec 1, 2022
Without this gem, current activeadmin version becomes incompatible with the master branch of `arbre`. It shouldn't be an issue as long as we update activeadmin's code to use keyword arguments everywhere, set a minimum dependency on the next `arbre` and release both gems at the same time, but I think it's easier to be conservative.
varyonic
added a commit
to varyonic/arbo
that referenced
this pull request
Dec 9, 2022
* render_in: Use `ruby2_keywords` for the moment (activeadmin#205) Deprecate Element#to_s and #to_str Add Document#render_in Use ActiveSupport::SafeBuffer instead of StringIO. require 'timeout' Use render_in(self) to build context cached_html. Add FieldsForProxy#render_in Deprecate using :to_s for rendering. Test using output_buffer from html tags matches #to_s. Add input and output variables to html rendering specs. Add Context#output_buffer, Element#render_in, ElementCollection#render_in, TextNode#render_in and Tag#render_in.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this gem, current
activeadminversion becomes incompatible with the master branch ofarbre. It shouldn't be an issue as long as we updateactiveadmin's code to use keyword arguments everywhere, set a minimum dependency on the nextarbreand release both gems at the same time, but I think it's easier to be conservative.So let's use
ruby2_keywords.