Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop dependency on ruby2_keywords #578

Merged

Conversation

Earlopain
Copy link
Contributor

Now that Ruby < 2.7 is not supported (#345) this isn't needed anymore

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (729a91d) to head (e0368b9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   94.34%   94.32%   -0.03%     
==========================================
  Files          17       17              
  Lines         460      458       -2     
==========================================
- Hits          434      432       -2     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala self-requested a review March 1, 2024 15:07
tagliala
tagliala previously approved these changes Mar 1, 2024
Copy link
Contributor

@tagliala tagliala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@javierjulio javierjulio dismissed tagliala’s stale review March 1, 2024 15:30

We can't merge this as is because several methods are prefixed with the ruby2_keywords symbol.

@Earlopain
Copy link
Contributor Author

Hi, the dependency is not needed anymore because ruby2_keyword methods are defined by ruby natively from 2.7 and up. It's only necesseary for downward compatibility.

$ rbenv local 2.6.10
$ irb
irb(main):001:0> RUBY_VERSION
=> "2.6.10"
irb(main):002:0> Module.respond_to?(:ruby2_keywords, true)
=> false

$ rbenv local 2.7.8
$ irb
irb(main):001:0> RUBY_VERSION
=> "2.7.8"
irb(main):002:0> Module.respond_to?(:ruby2_keywords, true)
=> true

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks!

Now that Ruby < 2.7 is not supported (activeadmin#345) this isn't needed anymore
@javierjulio javierjulio force-pushed the remove-ruby2_keywords-dep branch from a529589 to e0368b9 Compare March 2, 2024 01:36
@javierjulio javierjulio merged commit a8921bf into activeadmin:master Mar 2, 2024
18 checks passed
@Earlopain Earlopain deleted the remove-ruby2_keywords-dep branch March 2, 2024 06:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants