Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Datatrans: Modify authorization_from string for store #5193

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

gasb150
Copy link
Collaborator

@gasb150 gasb150 commented Jul 24, 2024

Summary:
Modify the string for store to be separated by '|' instead of '-'.

SER-1395

Tests
Remote Test:
Finished in 31.477035 seconds.
25 tests, 72 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 100% passed

Unit Tests:
Finished in 0.115603 seconds.
29 tests, 165 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

Rubocop
798 files inspected, no offenses detected

Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line still needs to change

Summary:
Modify the string for store to be separated by '|' instead of
'-'.

SER-1395

Tests
Remote Test:
Finished in 31.477035 seconds.
25 tests, 72 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:
Finished in 0.115603 seconds.
29 tests, 165 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop
798 files inspected, no offenses detected
@gasb150 gasb150 force-pushed the SER-1395_datatrans_tpv branch from ce85f62 to cced0fb Compare July 26, 2024 15:32
Copy link
Contributor

@naashton naashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for the quick fix.

@naashton naashton merged commit efd27e7 into master Jul 26, 2024
5 checks passed
@naashton naashton deleted the SER-1395_datatrans_tpv branch July 26, 2024 17:00
bryansquadup pushed a commit to givehub/active_merchant that referenced this pull request Aug 21, 2024
…#5193)

Summary:
Modify the string for store to be separated by '|' instead of
'-'.

SER-1395

Tests
Remote Test:
Finished in 31.477035 seconds.
25 tests, 72 assertions, 0 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications
100% passed

Unit Tests:
Finished in 0.115603 seconds.
29 tests, 165 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

Rubocop
798 files inspected, no offenses detected

Co-authored-by: Gustavo Sanmartin <gsanmartin@EN2010363.local>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants