new Serverless() not getting assigned correctly to this.serverless, Promise not resolving properly

[ShnkeWeber]

Expected behavior:

Code of function initializeServerless working properly and setting this.serverless to the generated sls

  async initializeServerless() {
    process.env.SLS_DEBUG = "*"

    const slsService = await ServerlessInvoker.loadServerlessYaml(
      path.join(this.servicePath, "serverless.yml")
    )
    const config = {
      serviceDir: path.dirname(this.servicePath),
      configurationFilename: "serverless.yml",
      configuration: slsService,
      commands: [],
      options: {},
    }
    const sls = new Serverless(config) // creates the new Serverless
    
    return sls.init().then(() => {
      sls.service.load().then(() => {
        sls.service.setFunctionNames({})
        sls.service.mergeArrays()
        sls.service.validate()
        **this.serverless = sls** // should set this.serverless to the created Serverless
      })
    })
  }

Actual behavior:

The initializeServerless function does not seem to set this.serverless = sls in time so that this.loadServerlessEvents throws an error as this.serverless is still null.
(TypeError: Cannot read properties of null (reading 'service') at ServerlessInvoker.loadServerlessEvents)

  async invoke(httpRequest, event, context) {
    // Read the serverless.yml file
    return this.initializeServerless()
      .then(() => **this.loadServerlessEvents()**) // error thrown by this function
      .then((httpEvents) => {
        // find the event that matches the specified httpRequest
        let httpEvent = httpEvents.find((e) => e.test(httpRequest))
        if (!httpEvent) {
          throw new Error(
            `Serverless http event not found for HTTP request "${httpRequest}" in service path "${this.servicePath}".`
          )
        }

async loadServerlessEvents() {
    let funcs = **this.serverless.service** // is null
      .getAllFunctions()
      .map((fname) => {
        let funcObj = this.serverless.service.getFunction(fname)
        let events = this.serverless.service.getAllEventsInFunction(fname)
        let f = {
          name: fname,
          handler: funcObj.handler,
          events: events.filter(
            (e) => Object.keys(e).includes("http") && e.http !== null
          ),
        }

Setting this.serverless = sls earlier or solved the problem for me:

    const sls = new Serverless(config)
   
    return sls.init().then(() => {
      **this.serverless = sls** // e.g. here
      sls.service.load().then(() => {
        sls.service.setFunctionNames({})
        sls.service.mergeArrays()
        sls.service.validate()
      })

Steps to reproduce the problem:

Create test class with a serverlessInvoker instance

private readonly serverlessInvoker = new ServerlessInvoker();

and exectue the invoke function

const response = await this.serverlessInvoker.invoke(
      'POST xyz',
      {}
    );

a serverless.yml

service: service

frameworkVersion: '3'

provider:
  name: aws
  runtime: nodejs18.x
  region: eu-central-1

resources:
  # externalize Resources to separated file to get support by IDE for cloudformation
  - ${file(serverless-resources.yml)}

serverless-resources.yml

Resources:
  OnlyApiRequestValidation:
    Type: "AWS::ApiGateway::RequestValidator"

Environment:

serverless-http-invoker 3.0.6
serverless 3.31.0
node 18
macOS 13.1.1

[github-actions]

🎉 This issue has been resolved in version 3.0.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀