Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove uses of pin_project::project attribute #1553

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Jun 5, 2020

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225

Although the deprecation of the project attribute has not been released yet, this PR is submitted in advance to avoid the CI from being broken by deprecated warnings.

pin-project will deprecate the project attribute due to some unfixable
limitations.

Refs: taiki-e/pin-project#225
@codecov-commenter
Copy link

Codecov Report

Merging #1553 into master will decrease coverage by 0.10%.
The diff coverage is 36.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
- Coverage   50.95%   50.84%   -0.11%     
==========================================
  Files         126      133       +7     
  Lines       12041    12067      +26     
==========================================
  Hits         6136     6136              
- Misses       5905     5931      +26     
Impacted Files Coverage Δ
actix-http/src/client/connection.rs 11.26% <0.00%> (+0.74%) ⬆️
actix-http/src/h2/dispatcher.rs 0.00% <0.00%> (ø)
src/responder.rs 83.76% <0.00%> (+0.43%) ⬆️
actix-http/src/service.rs 45.20% <33.33%> (+0.30%) ⬆️
actix-http/src/encoding/encoder.rs 81.81% <50.00%> (ø)
actix-http/src/body.rs 33.76% <62.50%> (+0.64%) ⬆️
actix-http/src/h1/dispatcher.rs 55.80% <71.42%> (+0.14%) ⬆️
actix-http/src/header/common/mod.rs 7.69% <0.00%> (-25.65%) ⬇️
actix-http/src/header/common/accept.rs 0.00% <0.00%> (ø)
actix-http/src/header/common/last_modified.rs 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a794504...6c5c4ea. Read the comment docs.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up!

@JohnTitor JohnTitor merged commit 4f9a1ac into actix:master Jun 6, 2020
@taiki-e taiki-e deleted the pin-project branch June 6, 2020 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants