Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: improve texture management in WebGpuResourceRepository #1512

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: improve texture management in WebGpuResourceRepository #1512

merged 1 commit into from
Jan 2, 2025
+11 −3

Conversation

emadurandal
Copy link
Collaborator

  • Added null check for texture before attempting to destroy and delete it, preventing potential runtime errors.
  • Enhanced mipmap generation logic by ensuring proper cleanup of associated texture views and bind groups before destroying the texture.
  • Streamlined resource management to improve performance and reliability during texture operations.

fix: improve texture management in WebGpuResourceRepository
94ef1d7 
- Added null check for texture before attempting to destroy and delete it, preventing potential runtime errors.
- Enhanced mipmap generation logic by ensuring proper cleanup of associated texture views and bind groups before destroying the texture.
- Streamlined resource management to improve performance and reliability during texture operations.
@emadurandal emadurandal merged commit c2994dd into main Jan 2, 2025
2 of 4 checks passed
@emadurandal emadurandal deleted the fix/generating-mipmap branch January 2, 2025 10:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emadurandal