update reset #5
Merged
update reset #5
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i was able to reproduce #3. also saw the same behavior that it **_did_** work with other boards (esp32-s3 tft feather and rp2040 feather). i think that the reset() function was raising the error because the DAC was resetting before the command was being acknowledged over I2C (this is noted in the [arduino driver](https://github.com/adafruit/Adafruit_AD569x/blob/6e725d0efbe4010b3971d011c6df82f64d6b0541/Adafruit_AD569x.cpp#L189)). i updated the function to not raise
ladyada
approved these changes
Dec 5, 2024
|
yay thanx! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 10, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_AD569x to 2.0.5 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_AD569x#5 from adafruit/reset_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.21 from 1.3.20: > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#25 from jposada202020/adding_displayio_example Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.18 from 1.0.17: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#9 from caternuson/iss8 Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.13.1 from 2.13.0: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#84 from mikeysklar/1680z-alignment Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.11.12 from 0.11.11: > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#26 from jposada202020/adding_displayIO_example Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.21 from 3.1.20: > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#26 from jposada202020/adding_displayio_example Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.3.0 from 1.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_datetime#27 from FoamyGuy/isoformat_Z_parse Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.4.21 from 1.4.20: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#31 from FoamyGuy/use_ruff Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.3.0 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#73 from adafruit/side-set-pindirs-directive Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 3.1.2 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#48 from FoamyGuy/visible_turtle_loc_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was able to reproduce #3. also saw the same behavior that it did work with other boards (esp32-s3 tft feather and rp2040 feather). i think that the reset() function was raising the error because the DAC was resetting before the command was being acknowledged over I2C (this is noted in the arduino driver). i updated the function to not raise