Update font documentation for display_text() #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the underlying text display library may have evolved out from under this library. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 10, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 2.1.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#65 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.7.3 from 2.7.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#66 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.0.5 from 3.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#199 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.2.1 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#42 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.20.1 from 1.20.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#77 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.3.2 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#50 from haugenmitch/update-display_text-documentation > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#51 from adafruit/dhalbert-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_miniQR to 2.1.0 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#25 from prcutler/root-group-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
display_text()documentation is incorrect in my testing. It is not sufficient to simply provide a font file path string to thefontargument of this method. You must provide the font in the form of an object which subclassesFontProtocolor otherwise provides theget_bounding_box()andget_glyph()methods. I am proposing this change to the documentation to clear up the usage of this parameter.