Remove secrets and more #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhalbert, can't add you as a reviewer. This one is needed before we remove |
|
Realized I added vars for AIO that aren't needed in the example. Fixed and ready for review. |
dhalbert
approved these changes
Feb 23, 2025
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 23, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 7.0.0 from 6.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#137 from justmobilize/remove-secrets-and-more
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates to remove secrets usage and update keys:
secrets_dataas it will be pulled fromPortalBasesecrets.pycomments tosettings.tomlAIO_*toADAFRUIT_AIO_*JSON_URLTested both edited examples on a PyPortal running 9.2.4