Skip to content

Fixes for render functions chunk_size parameter and negative skipped linesin error message #5

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Nov 2, 2024

Conversation

michalpokusa
Copy link
Contributor

@michalpokusa michalpokusa commented Oct 30, 2024

🪛Fixes:

  • Removed unnecessary _yield_as_sized_chunks in render_... functions
  • Added check for skipped lines in TemplateSyntaxError to avoid messages like "[-1 lines skipped]"

🏗️ Refactor:

  • Renamed _CACHE to CACHED_TEMPLATES

@michalpokusa michalpokusa changed the title Fixes and refactor Fixes for render functions chunk_size parameter and negative skipped linesin error message Oct 30, 2024
@michalpokusa michalpokusa marked this pull request as ready for review October 31, 2024 00:04
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested successfully with a modified simpletest on a Feather S3 TFT.

@FoamyGuy FoamyGuy merged commit be78fc3 into adafruit:main Nov 2, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 3, 2024
@michalpokusa michalpokusa deleted the fixes-and-refactor branch December 20, 2024 20:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants