Skip to content

Remove SocketPoolContants #162

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2024
Merged

Remove SocketPoolContants #162

merged 2 commits into from
May 21, 2024

Conversation

justmobilize
Copy link
Collaborator

@justmobilize justmobilize commented May 20, 2024 •
edited
Loading

Remove mis-spelled SocketPoolContants and place the constants where they should be

@justmobilize
Copy link
Collaborator Author

@dhalbert this replaces #161

@justmobilize justmobilize marked this pull request as ready for review May 20, 2024 22:57
@dhalbert dhalbert mentioned this pull request May 20, 2024
Closed
dhalbert
dhalbert requested changes May 20, 2024
View reviewed changes
dhalbert
dhalbert approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is simpler!

@dhalbert dhalbert merged commit fe0e02a into adafruit:main May 21, 2024
1 check passed
@justmobilize justmobilize deleted the remove-socket-pool-contants branch May 21, 2024 17:33
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 22, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c89a027)
123f7fe 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 8.3.0 from 8.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#206 from justmobilize/remove-timeout-exception
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#205 from justmobilize/remove-socket-pool-contants

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.1.1 from 7.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#162 from justmobilize/remove-socket-pool-contants
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#163 from justmobilize/remove-timeout-exception

Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.8.1 from 7.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#217 from justmobilize/update-comments

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justmobilize @dhalbert