Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

skip any chunks between fmt and data in .wav files #10013

Merged

Conversation

MarshallMiller
Copy link

@MarshallMiller MarshallMiller commented Jan 29, 2025

This patch adds support for wave files that include chunks between the fmt and data chunks. Any such chunks are ignored. I have attached a file that includes a wave file without any extra chunks and a wave file with an extra (LIST) chunk. They were produced by running the following commands:

ffmpeg -i 16000.mp3 -acodec pcm_s16le 16000-with-list-chunk.wav

ffmpeg -i 16000.mp3 -bitexact -acodec pcm_s16le 16000-without-list-chunk.wav

extra-chunk-test.zip

@dhalbert
Copy link
Collaborator

Hi, could you explicate what this is doing? I'd suggesting editing the original post.

@MarshallMiller
Copy link
Author

Sorry for not including a description. I have edited it. Hopefully it makes sense.

@dhalbert dhalbert changed the title skip any chunks between fmt and data skip any chunks between fmt and data in.wav files Feb 4, 2025
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert changed the title skip any chunks between fmt and data in.wav files skip any chunks between fmt and data in .wav files Feb 4, 2025
@dhalbert dhalbert merged commit 11711fd into adafruit:main Feb 4, 2025
494 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants