SAMD51 SPI Secondary Mode #9385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in and parameter passing has issues
…o adafruit-9.0.x Rebasing onto 9.0.3 (plus 4 commits) from 9.0.0-alpha, to get updates that fix asyncio library
…erted Metro M4 Express board configurations to original
…ld scripts to build firmware for rapid0 boards, updated peripherals submodule
|
Hi, just wanted to follow up to see if there's changes to be requested on this feature. I added some commits a few months back to address the concerns you've expressed so far. I know you guys are busy, let me know how I can help or if there's something I missed! |
tannewt
requested changes
Feb 6, 2025
Randall-Scharpf
force-pushed
the
main
branch
from
7d97045 to
193f700
Compare
|
I've made the requested changes and gotten the CI tests to pass; let me know if there's any problems that introduced or anything else to fix that I've missed! |
tannewt
requested changes
Feb 11, 2025
ports/atmel-samd/boards/adafruit_pixel_trinkey_m0/mpconfigboard.h
Outdated
Show resolved
Hide resolved
…pixel_trinkey_test# Please enter a commit message to explain why this merge is necessary,
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2131. Tested on a pair of custom breakout boards which were derived from the Metro M4 Express.