Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update cdc_enumerate.c #205

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Update cdc_enumerate.c #205

merged 1 commit into from
Feb 13, 2024

Conversation

NasserN
Copy link

@NasserN NasserN commented Sep 1, 2023

'c' should be initialized to 0, throws warning (treated like an error) otherwise.

'c' should be initialized to 0, throws error 1 otherwise.
@NasserN
Copy link
Author

NasserN commented Sep 1, 2023

src/cdc_enumerate.c:725:5: error: 'c' may be used uninitialized [-Werror=maybe-uninitialized] 725 | USB_Write(&c, 0, 0); | ^~~~~~~~~~~~~~~~~~~ src/cdc_enumerate.c:669:10: note: by argument 1 of type 'const void *' to 'USB_Write' declared here 669 | uint32_t USB_Write(const void *pData, uint32_t length, uint8_t ep_num) { | ^~~~~~~~~ src/cdc_enumerate.c:724:13: note: 'c' declared here 724 | uint8_t c; | ^

@petejohanson
Copy link

Any way we can get this merged? Have experienced this recently, as have others using this bootloader with ZMK on custom samd21 boards.

Copy link

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I won't make a release for this right away, but it will be on master.

@dhalbert dhalbert merged commit f2d1b44 into adafruit:master Feb 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants