Skip to content

Commit

Permalink
Improved table styling (i.e., copied Github). Updated README and desc…
Browse files Browse the repository at this point in the history
…ription with some recent changes.
  • Loading branch information
adam-p committed Jun 6, 2012
1 parent 5c29b49 commit 386851c
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 11 deletions.
11 changes: 1 addition & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,6 @@ firefox/
## Next Steps
* Improve table styling.
* Figure out how to prevent users from losing modifications to the rendered version when they revert.
* Prompted by [this Reddit comment](http://www.reddit.com/r/programming/comments/uagqd/write_email_in_markdown_then_make_it_pretty/c4u6cpv).
* Maybe add an option to make rendered mode read-only. If a user edits the rendered text and then reverts, they lose their changes, which is pretty bad. Better to not let the user make changes at all (optionally).
Expand All @@ -195,13 +193,6 @@ firefox/
* Test cases.
* Syntax hightlighting!
* [SyntaxHighlighter](http://alexgorbatchev.com/SyntaxHighlighter/)
* [Highlight.js](http://softwaremaniacs.org/soft/highlight/en/)
* [google-code-prettify](https://code.google.com/p/google-code-prettify/)
* [Rainbow](http://craig.is/making/rainbows)
* There are more that require jQuery, but I just took it out…
* Add user option to create custom CSS.
* Add a configurable hotkey.
Expand Down Expand Up @@ -232,7 +223,7 @@ firefox/
* Based on the Chrome extension pattern described in [antimatter15 / hideelements](https://github.com/antimatter15/hideelements).
* Markdown-to-HTML: [chjj / marked](https://github.com/chjj/marked)
* HTML-to-text: [mtrimpe / jsHtmlToText](https://github.com/mtrimpe/jsHtmlToText)
* Github-style CSS: [somebox's gist](https://gist.github.com/1082608)
* Syntax highlighting: [isagalaev / highlight.js](https://github.com/isagalaev/highlight.js)
* Icons by [dunedel via IconArchive](http://www.iconarchive.com/show/kaori-icons-by-dunedhel/Other-Butterfly-icon.html) (CC BY-NC-ND 3.0)
### Other stuff not used, but to keep an eye on
Expand Down
35 changes: 34 additions & 1 deletion src/common/github.css.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ var markdownHereCss = ' \
\
/* This is the overall wrapper, it should be treated as the `body` section. */ \
.markdown-here-wrapper { /* adam-p: changed from body */ \
font: 13px Helvetica,arial,freesans,clean,sans-serif; \
font: 14px Helvetica,arial,freesans,clean,sans-serif; \
color: #333; \
background-color: #fff; \
border: none; \
Expand Down Expand Up @@ -83,6 +83,39 @@ h6 { \
.shadow { \
box-shadow:0 5px 15px #000; \
} \
table { \
padding: 0; \
margin: 15px 0; \
border-collapse: collapse; \
border-spacing: 0; \
font-size: 100%; \
font: inherit; \
border: 0; \
} \
tbody { \
margin: 0; \
padding: 0; \
border: 0; \
} \
table tr { \
border: 0; \
border-top: 1px solid #CCC; \
background-color: white; \
margin: 0; \
padding: 0; \
} \
table tr:nth-child(2n) { \
background-color: #F8F8F8; \
} \
table tr th, table tr td { \
border: 1px solid #CCC; \
text-align: left; \
margin: 0; \
padding: 6px 13px; \
} \
table tr th { \
font-weight: bold; \
} \
\
/* \
\
Expand Down
4 changes: 4 additions & 0 deletions store-assets/description.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ Change Log

Email signatures are now excluded from conversion. Signatures must be preceded by "-- " (note the space at the end).

Much improved table styling. (More like Github's.)

Better styling consistency across browsers and mail clients.


2012-05-31: v2.1.3

Expand Down

0 comments on commit 386851c

Please # to comment.