Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Define fiscal month as starting on START_DAY #19

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

adamjstewart
Copy link
Owner

Fixes #18

@jbb04 @nicmendoza can you test this and see if it makes sense? If it looks good I can create a new release with this bug fix.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #19 (4bdb6e0) into master (bf76d51) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          527       530    +3     
=========================================
+ Hits           527       530    +3     
Impacted Files Coverage Δ
fiscalyear.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf76d51...4bdb6e0. Read the comment docs.

@adamjstewart
Copy link
Owner Author

@jbb04 @nicmendoza reminder to test this PR.

@adamjstewart adamjstewart merged commit eab150a into master Jun 10, 2021
@adamjstewart adamjstewart deleted the fixes/fiscal-month branch June 10, 2021 22:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fiscal Month Offset
2 participants