refactor(framework) Update the constructor of RecordSet
#4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
reviewed
Mar 3, 2025
Comment on lines
+160
to
+162
| if records is not None: | ||
| for key, record in records.items(): | ||
| self[key] = record |
There was a problem hiding this comment.
I believe the __setitem__ needs to be tweaked since this:
from flwr.common import RecordSet, MetricsRecord, ConfigsRec
c = RecordSet({'a':MetricsRecord(), 'a': ConfigsRecord()})won't throw a warning and the resulting record won't have a MetricsRecord.
There was a problem hiding this comment.
I don't think we can do anything about it, really, b/c:
There was a problem hiding this comment.
What we get is already a dictionary that only has one item. Users will see a warning if they manually set rs["a"] = MetricsRecord() and then rs["a"] = ConfigsRecord().
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.